Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • A Ahad Mobile
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • holatech
  • Ahad Mobile
  • Merge requests
  • !136

fix(fe,be): borrow/loans UI batch — five medium UI bugs

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Hung Hoang requested to merge hunghoang/fix/borrow-ui-batch into develop Oct 22, 2026
  • Overview 1
  • Commits 12
  • Pipelines 5
  • Changes 23

Per-bug commits, each referencing its Lark record:

  1. Borrow detail header -> "Borrowed Detail" (per tester note, to distinguish from Earn; Figma still says "Loan Details" and should be updated).
  2. Passcode eye toggles on the set/change passcode form (change-password already had them).
  3. KYC issuing-country prefill from the signup phone country (fixedInfo.country, alpha-3 from the shared country-code helper; covers new, existing and resumed applicants; never overwrites an existing country; fail-open with 3s request timeouts).
  4. Receipt secondary action follows the operation kind: BORROW -> "View Borrow" -> /list-borrow.
  5. Hub debt display: new bookedDebtValue (settled only) feeds "Currently borrowing"; debtValue/healthFactor/ltv/liquidationPrice stay on the full risk context.

Verification

  • Bugs 1, 2, 4, 5: verified end-to-end with .maestro/borrow-ui-batch-verify.yaml (32 steps) on an isolated local backend + dev-client simulator: hub shows $4.00 booked with no $10.00, HF stays risk-true at 8.99, "Borrowed Detail" header, "View Borrow" receipt, passcode toggles.
  • Bug 3: verified at payload/unit level only (createApplicant fixedInfo.country; resumed and existing-applicant PATCH paths; never-overwrite; fail-open on profile/GET/PATCH failure; real-axios hang tests for the 3s timeout). Sumsub SDK UI behavior on a fresh and a resumed applicant is PENDING sandbox verification with a non-VN signup account - no Sumsub credentials are available locally.
  • FE: type-check clean; loans + passcode suites pass. BE: kyc + sumsub + lending summary/controller suites pass; tsc error count identical to develop baseline; no new lint errors vs develop.

Known follow-ups: product to confirm the hub's booked-debt figure next to risk-true HF/utilisation during a pending borrow; bug 3 sandbox check as described above.

Edited Oct 22, 2026 by Hung Hoang
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hunghoang/fix/borrow-ui-batch